Skip to content

Added .class to LogManager #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024
Merged

Added .class to LogManager #128

merged 2 commits into from
May 23, 2024

Conversation

surajkumar
Copy link
Contributor

@surajkumar surajkumar commented May 23, 2024

When running from a .jar file, Log4J was throwing an exception that it couldn't find some class. Turns out we need to add .class to LogManager

Added fat jar config to example-bot

This PR also includes an important fix: Annotations were not loading when the project was ran directly from a .jar file

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@surajkumar surajkumar merged commit 4a40c37 into main May 23, 2024
4 of 5 checks passed
@surajkumar surajkumar deleted the fix-logger branch May 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant